Owen Wu

Results 85 comments of Owen Wu

@awelc @tnowacki I implemented the telemetry/event protocol of PSL, so that I can wait for the Symbolicator to be ready before initiating the call. Now that the CI check has...

> Symbolicator Since the current implementation of Symbolicator is asynchronous, the specific timing of Symbolicator depends on the size and running environment of the project, and by setting a fixed...

@awelc The code has been updated and needs to be reviewed again.

> > @awelc The code has been updated and needs to be reviewed again. > > I am going to re-review it shortly, but I was wondering if you are...

> > > @awelc The code has been updated and needs to be reviewed again. > > > > > > I am going to re-review it shortly, but I...

I closed by mistake and now reopen.

> > > Symbolicator > > > > > > Since the current implementation of Symbolicator is asynchronous, the specific timing of Symbolicator depends on the size and running environment...

@awelc I've done the refactoring, take the time to review it again.

> > @awelc I've done the refactoring, take the time to review it again. > > Thank you! And my apologies that it's taking time, but I want to make...

> > Your analysis is correct, my problem now is that ci-test will fail if not synchronously waiting for symbol table resolution to complete. Another solution is to set a...