Youssouf Oumar comments

Results 7 comments of


                                            Youssouf Oumar

Cleanup when unmounting component

Hi @mnebuerquo ! Can you make it a minimal reporductible example, with the the help of a [CodeSandbox](https://codesandbox.io/s/new), for example?

[eslint-plugin] Better parsing to correctly validate various values

The ESLint rule seems to already support any string as we have: [`const color = makeUnionRule(isString, isNamedColor, isHexColor)`](https://github.com/facebook/stylex/blob/main/packages/eslint-plugin/src/stylex-valid-styles.js#L151). Plus, I'm not getting any error with the given example with the...

[eslint-plugin] Better parsing to correctly validate various values

Sorry, in a hurry I misunderstood I guess. Thanks @nedjulius!

[eslint-plugin] Better parsing to correctly validate various values

So should we wait for the parser before working on this issue @nmn? As a matter of fact, I started looking at it, implemented already a validation for `rgb`, `rgba`,...

[eslint-plugin] sort keys rule should sort object keys when applying fix

Hi @nmn ! I'm looking at it but cannot reproduce it. Do you have an example?

[eslint-plugin] sort keys rule should sort object keys when applying fix

Thanks for the example. You are clicking on “fix this line”, isn't that what's supposed to do? Can ESLint itself do otherwise? Also, what about the fact that on save...

[eslint-plugin] sort keys rule should sort object keys when applying fix

I see @nmn, thanks!