Yotam Ofek
Yotam Ofek
Ah great, now it failed due to a different spurious and unrelated problem 😅 Let's run CI again.. Edit: seems the previous failure was not spurious and was fixed by...
In case anyone is interested in this, here is a little wrapper I made to be able to use this library with stage-2 decorators: https://gist.github.com/yotamofek/2ad8fd67af4ba00458fe1eaac30d7011 This is very much POC-quality,...
Well, my assumption that it is non-optimal is as naive as my implementation itself. :) I'm guessing a few layers of scoping and closures can be reduced by re-writing the...
Hey @wycats - so, I've been playing around a little more with "porting" this library to use stage-2 decorators, and I might have a few pairs of cents to give...
@StanislavGlebik Glad to know there's actual interest in this. :) I've been using this code for production stuff for a few weeks now, but have put off updating it to...
I think [`abs_diff`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.abs_diff) is also relevant to this issue. (My WIP lint is here: #14482 )
@bors try @rust-timer queue
Putting this up for review. Perf is mostly neutral (secondary benchmark that regresses looks bimodal?), so not sure at all whether it's worth the effort and complexity that this adds....
> Some of these changes have some overlap with #146436. They might conflict if one gets merged before the other, but yours doesn't actually touch the ESI implementations.