Martin Price

@indigoxela - is it documented somewhere the correct/official form of the required HTML attribute? The `required="required"` used appears [here](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required) However [this site](https://www.w3schools.com/tags/att_required.asp) and [this site](https://www.geeksforgeeks.org/html-input-required-attribute/) simply have `required`. I think...

I think this is functionally great. I personally think `required="true"` is clearer for someone looking at the code and would prefer that, but I wouldn't let it stand in the...

The failed test is nothing to do with what I've changed: Detailed test results --------------------- ---- Upgrade path: Bare upgrade test (BareUpgradePathTestCase) ---- Status Group Filename Line Function ------------------------------------------------------------------------------------------------------------------------ Fail...

Closing and reopening to see if test fail can be cleared.

@quicksketch - I've tested this on my LiteSpeed hosting and it works as expected. I've added a comment as to whether we should also update the text in line 249.

@quicksketch - I was made aware that this is still open as Dragon Bot emailed me to notify of a new tugboat preview. Should just need some text changing to...

+1 from me as well

@Pamplemousse - look at the issue numbers #386 is a duplicate of this.

I've reviewed this again and it all looks good. The addition to regex in the test looks good.

I see phpcs strikes again. As none of these apply to the changes, I don't think this should block. Also the 5.6 test failure seems unrelated to the change. I've...