Yonatan Komornik

Results 16 comments of Yonatan Komornik

I think we should be able to remove these heuristic and replace them with an actual Shannon entropy estimation. As I already have a pretty precise and fast estimator, we...

> Was this fixed by #3051? I don't think so, as this looks like a memory access violation and not resource starvation. More likely it's the bug(s) that's being fixed...

Thank you for reporting @vnair81. Closing the issue, please reopen if there are any further questions.

> @terrelln did you ever have a chance to investigate this? I'll take a look at this today / tomorrow.

An update: I've reproduced the problem and found the root cause. There's indeed a bug in the windows threading translation layer. Will put up a PR with a fix soon.

Looks good, although a bit unstable as the windows test might actually pass sometimes. Merging so we can merge the other PR that solves the bug and would fix the...

More complete solution merged, see #3528

Hi @jbms , Thank you for your contribution, I'm not a CMake expert but I don't feel comfortable with the solution - it changes an interface that other users may...

Added an issue to implement the flag based solution (#3468). Closing this PR.

Hi and sorry for the delayed response. There's a good chance that there are two separate environment-related problems here. @itsManjeet - error code 10 is [unknown prefix](https://github.com/facebook/zstd/blob/bad7f82300d3d2a1c835ca577b71cba3626dfb4a/lib/zstd_errors.h#L55) which can happen...