Yogesh Khater

Results 37 comments of Yogesh Khater

hey @jeffijoe , thanks for supporting v6 🍻 We were doing an upgrade in our app and found that v6 recommends calling `makeObservable(this)` in the constructor of mobx specific classes....

Understood, thanks @jeffijoe! When we upgraded mobx to v6 in our app where we inherit all stores from `Model` and which uses `1.0.0-alpha.2`, I found one weird issue with `makeObservable(this)`....

Ah wait, I think explicit `set` is needed when we define annotations without decorator pattern ```js // In tsconfig.json "compilerOptions": { ... "useDefineForClassFields": true, } ``` ```js class M extends...

Aha that's cool! We kind of do similar thing where we've multiple stores defined instead of single root store. They can initialize one or more collections as required. I see...

Hi @ibrahima, thanks for reporting this issue. I think this is a valid point and `find_by` implementation should be changed to consider all given options, something like below. ```ruby def...

Makes sense. @apotonick I think we should not mutate the `options` ? We can now access `from` as a kwarg too. ```ruby def unnest(name, from:, **options) ... end ```

@nirvdrum Thanks, fixed it. It seem the difference between forwarded and delegated method has been increased in ruby >= 2.7. ```ruby Warming up -------------------------------------- method 307.381k i/100ms forwarded method 228.038k...

Good idea about `safe_match?`. Though, instead of catching `ArgumentError` and returning `nil` (which would ignore that occurrence I suppose), maybe we can replace invalid occurrences with blank string as suggested...

But we would need to initialize `Graph` object and I'm thinking if it would incur any additional cost, like generating intermediate structures in future.