yoff
yoff
Yep, looks great :-)
Force pushed because I could see that my amended commit message to the last commit had not been pushed.
The diagram looks correct to me. Is the difference with Ruby just that we have not (yet?) written any standard library models using flow summaries? Or is there a more...
The failing language test belongs to `https://github.com/github/semmle-code` and cannot be fixed in this PR (I believe the fix is simply to update the test expectations).
> A few drive-by comments. Is the logic actually hooked up yet? I fail to see references to e.g. any of the `FlowSummaryImpl::Private::Steps` predicates. See e.g. `DataFlowPrivate.qll` for ruby for...
> I think in terms of the implementation, this looks pretty solid. I've added a bunch of requests for clarification (and also some requests for renaming stuff). I'll be very...
> ## General comments: > Can we add ONE production flow-summary? For example for the builtin `reversed` -- just to see where it would go, and how it looks 😊...
> 🤞 for the tests 😆 Indeed, thanks for the fix :-)
It might be fine to simply have an opt-in warning for every non-private entity in any file. I think we would like to document most of those anyway.