ymfact

Results 5 issues of ymfact

GetTypeByMetadataName returns null, and causes null reference exception. Please ban Microsoft.CodeAnalysis.Compilation.GetTypeByMetadataName for the entire repository. See this: [Compilation.GetTypeByMetadataName returns null even though the other ObsoleteAttribute is internal](https://github.com/dotnet/roslyn/issues/3864)

I got "Reentering the Update method is not allowed" exception on WaitForCompletion. Here's a reproducible example. ```C# await Addressables.LoadContentCatalogAsync(someValidCatalogPath); Addressables.LoadAssetAsync(someValidKey).WaitForCompletion(); ```

ZipObservable has wrong OnCompleted timing. ```csharp var source1 = new Subject(); var source2 = new Subject(); var observable = Observable.Zip(source1, source2, (x, y) => $"{x}{y}"); observable.Subscribe( onNext: Console.WriteLine, onCompleted: ()...

When OnCompleted is called on a Subject, the associated ReadOnlyReactiveProperty's OnCompleted should also be invoked, but it is not happening as expected. ```csharp var subject = new Subject(); var readOnlyReactiveProperty...

There is an issue with the incorrect usage of `NotNullAttribute` in the `UnityEngine.Component.transform` property. In the file `resharper-unity/resharper/resharper-unity/src/annotations/UnityEngine.xml`, the following entry is present: ```xml ``` This annotation is incorrect because...