Yim Lee

Consider defining type alias for dimension `(String, String)`

1

### Expected behavior It should be clear what each `String` in a dimension tuple represents. ### Actual behavior Saw this code and had to google search to remind myself that...

FAILED: InterceptorTests.test_interceptor_shouldInterceptSignals

1

``` 11:02:19 Test Case 'InterceptorTests.test_interceptor_shouldInterceptSignals' started at 2022-06-10 18:02:19.205 11:02:19 :0: error: InterceptorTests.test_interceptor_shouldInterceptSignals : threw error " 11:02:19 try p.expectNoMessage(for: .milliseconds(500)) 11:02:19 ^~~~~~~~~~~~~~~~ 11:02:19 error: Received unexpected message [_ChildTerminated(/user/theWallsHaveEarsForTermination/stopperTwo)]:_ChildTerminated. Did...

https://ci.swiftserver.group/job/swift-distributed-actors-5.7-prb/66/consoleFull ``` DistributedReceptionistTests.test_receptionist_listing_shouldEndAfterTaskIsCancelled : failed - Expected [/user/Greeter-y] to terminate within 5s 22:53:57 ------------------------------------- ClusterSystem(DistributedReceptionistTests) ------------------------------------------------ 22:53:57 Captured log [DistributedReceptionistTests][2022-07-08 5:53:55.3360] [ClusterSystem.swift:915] [warning] Assign identity 22:53:57 // metadata: 22:53:57 //...

FAILED: ClusterLeaderActionsClusteredTests.test_up_ensureAllSubscribersGetMovingUpEvents

2

``` 12:48:41 Test Case 'ClusterLeaderActionsClusteredTests.test_up_ensureAllSubscribersGetMovingUpEvents' started at 2022-06-10 19:48:34.702 12:48:41 [19:48:36.8180] /code/Tests/DistributedActorsTests/Cluster/ClusterLeaderActionsClusteredTests.swift:198 : Cluster.Events on ActorTestProbe(/user/$testProbe-0/$messageAdapter) 12:48:41 [19:48:36.8190] /code/Tests/DistributedActorsTests/Cluster/ClusterLeaderActionsClusteredTests.swift:205 : Captured event: snapshot(Membership(count: 1, leader: .none, members: [Member(sact://first:[email protected]:9001, status: joining,...

When we move the singleton from one node to another, the two nodes involved can notify each other so there is a more graceful transition. This is to minimize the...

https://ci.swiftserver.group/job/swift-distributed-actors-5.9-prb/34/consoleFull ``` 11:42:41 /code/Tests/DistributedClusterTests/Cluster/SWIM/SWIMActorClusteredTests.swift:218: error: SWIMActorClusteredTests.test_swim_shouldPingSpecificMemberWhenRequested : failed - Expected ack, but got nack(target: SWIMActor(sact://[email protected]:9003/user/swim), sequenceNumber: 13) 11:42:41 :0: error: SWIMActorClusteredTests.test_swim_shouldPingSpecificMemberWhenRequested : threw error " 11:42:41 throw testKit(firstNode).fail("Expected ack, but...

FAILED: ClusterLeaderActionsClusteredTests.test_ensureDownAndRemovalSpreadsToAllMembers

1

https://ci.swiftserver.group/job/swift-distributed-actors-5.8-prb/45/consoleFull ``` 11:33:38 /code/Tests/DistributedClusterTests/Cluster/ClusterLeaderActionsClusteredTests.swift:336: error: ClusterLeaderActionsClusteredTests.test_ensureDownAndRemovalSpreadsToAllMembers : failed - No result within 20s for block at /code/Tests/DistributedClusterTests/Cluster/ClusterLeaderActionsClusteredTests.swift:336. Queried 4 times, within 20s. Last error: 11:33:38 case let other: throw testKit.error("Expected...