Yiğit Yüce comments

Results 20 comments of


                                            Yiğit Yüce

Failed to Compile after version upgrade of react-router-dom from 5V to V6

Feature: Allow for vertical stacking of icons

It can be done with your css.

feat(renderer): add flag to update default slot text content

hi @christian-bromann > Is there any reason this wouldn't work for you? What if I don't wrap the "Content text" with `span` element and want to update it? what would...

feat(renderer): add flag to update default slot text content

**EDIT: this case is not valid, please IGNORE this message** and one more example that comes up my mind is like that: ```tsx // component lib file @Component({ tag: 'my-component'...

feat(renderer): add flag to update default slot text content

Hi @christian-bromann > Can you share this as a Stackblitz project? I tried to reproduce but I realized it is my bad, it is **NOT a valid case**, so pls...

feat(renderer): add flag to update default slot text content

hey @christian-bromann I understand your concerns and you have a valid point so I'm closing this PR. Thanks for the discussion and for showing the point of your view clearly.

fix(runtime): add root scope id to the nested child as classname

hey @christian-bromann were you able to check the updates in the PR?

fix(runtime): add root scope id to the nested child as classname

> @yigityuce one little ask, it seems like this causes some unit test failures, mind taking a look and update the expectations in the tests? @christian-bromann done 🎉

bug: missing root element's scope id as classname in nested child

@christian-bromann PR is updated

bug: missing root element's scope id as classname in nested child

closing the issue since #5704 is merged 🚀 thanks all!