Yifan Cai

Results 8 comments of Yifan Cai

Can you add the delta coverage execution as part of the CircleCI build? Since unit and integration test are split across multiple pipelines, (unit first, then integration). I think you...

Why not a guardrail? I know it is following the existing properties. Probably makes sense to be a guardrail moving forward. WDYT?

I have yet to take another look at the implementation of the async timeout. Just noticed that `CHANGES.txt` needs to be updated.

Hi, @adelapena. Firstly, thanks for the patch. If my understanding is correct, the fix is to divide the mutations by schema change into multiple groups. What concerns me is that...

> Hi, @adelapena. Firstly, thanks for the patch. > > If my understanding is correct, the fix is to divide the mutations by schema change into multiple groups. What concerns...

> Hi, @yifan-c. Thanks for looking into this. So you think that the current fix is correct, with the wait in `handleMutation`? Put my comment in the JIRA ticket since...

My feedback on parser.g. https://github.com/yifan-c/cassandra/commit/1d78e80f364f7dd70d5c76298def125f478afe95 - removed some redundant definitions - permit using check and length as column names

I will take another pass, since there are considerable amount of changes since my last review.