Ryan

Hi, I have a suggestion about error handlings for locking. Would it be better to handle the possible errors that return from [pthread_mutex_lock](https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3p.html). https://github.com/TurboGit/hubicfuse/blob/788b9db6c0768136a0323a0f0f88a07d70897d45/cloudfsapi.c#L104-L112 https://github.com/TurboGit/hubicfuse/blob/b460f40d86bc281a21379158a7534dfb9f283786/commonfs.c#L461-L466 Possible situations that return errors....

An improper locking bug on the lock wiimote->rpt_mutex

1

Hi, developers, thank you for your checking. It seems the lock `wiimote->rpt_mutex `is not released correctly when `!rpt_mode & CWIID_RPT_IR==1` and `exec_write_seq(wiimote, seq_len, ir_enable_seq)==1` in the function `update_rpt_mode`? https://github.com/abstrakraft/cwiid/blob/fadf11e89b579bcc0336a0692ac15c93785f3f82/libcwiid/state.c#L144 ```...

Hi developers, in the below codes, the lock `daemon` could be not released before program's exit abort();. I think it is better to write` MHD_ip_count_unlock (daemon);` before the `abort();` for...

Missing error handlings for pthread_mutex_lock

4

Hi, I have a suggestion about error handlings for locking. Would it be better to handle the possible errors that return from pthread_mutex_lock. It seems there are some places missing...

Improper locking bugs due to the unrelesed locks before destorying

1

Hi, developers, thank you for your checking! Should the lock be released before destroying it(Line 158 and 164)? According to [this,](https://pubs.opengroup.org/onlinepubs/007904875/functions/pthread_mutex_destroy.html) it says It shall be **safe** to destroy an...

An error when building SockFuzzer on Mac

5

Hi, Developers: I encountered an error when building. Does it miss a file? Thank you for your help. ``` /Users/xx/Documents/tools/SockFuzzer/fuzz/net_fuzzer.cc:29:10: fatal error: 'fuzzer/FuzzedDataProvider.h' file not found #include ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error...

An improper locking bug(e.g., deadlock) on the lock ltc_ecc_fp_lock

3

Hi, developers, thank you for your checking. It seems the **lock ltc_ecc_fp_lock** is not released correctly when **cache_entry == NULL** in the function **ltc_ecc_fp_save_state**? https://github.com/libtom/libtomcrypt/blob/673f5ce29015a9bba3c96792920a10601b5b0718/src/math/fp/ltc_ecc_fp_mulmod.c#L1412-L1433

An improper locking bug(e.g., deadlock) on the lock &mutex

1

Hi, developers, thank you for your checking. It seems the lock `mutex` is not released correctly when `write(daemon_pipe[1], &type, 1) != 1` in the function `dispatch_request`? https://github.com/flowgrind/flowgrind/blob/9618dd3dc791dd8321f30215866afd655b5783e6/src/daemon.c#L1504-L1514

An improper locking bug(e.g., deadlock) on the lock global_mutex

3

Hi, developers, thank you for your checking. It seems the lock `global_mutex` is not released correctly when `!global.grain_envelope== 1` and `!sampleset_init()==1` in the function y_instantiate? https://github.com/smbolton/whysynth/blob/32e4bc73baa554bb1844b3165e657911f43f3568/src/dssp_synth.c#L110-L141 Best,

A possible null pointer dereference

2

Hi, can `fdopen` return null value? the value should be checked before passing to `fgets`? Thank you for checking. https://github.com/openssl/openssl/blob/9710d72b95f4fc218ed613f42dc90ad0d263b14f/apps/speed.c#L3511-L3512