Wang Yanlin comments

Results 6 comments of


                                            Wang Yanlin

[CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

I add a test case in RelToSqlConverterTest, it seems to produce a correct sql ``` @Test public void testGroupByWithLimitPlan() { String query = "SELECT sum(\"salary\") FROM \"employee\" group by \"gender\"...

[CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

Currently, I'm using `RelToSqlConverter` in my project, so I spent some time on this. I tried to fix this in `buildAggregate`, and it's affected 5 test cases in `RelToSqlConverterTest`. Here...

[CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

We can reproduce the case in `RelToSqlConverterTest`, you can apply `SortProjectTransposeRule.INSTANCE` rule to make sure Sort transpose Project

[WIP][CALCITE-3385] fields in diffrent tables has the same order will occur a bug.

You seem to use a wrong title for this PR.

[WIP][CALCITE-3385] fields in diffrent tables has the same order will occur a bug.

I think you may need this https://github.com/apache/calcite/pull/1439 to update your commit log.

[WIP][CALCITE-3385] fields in diffrent tables has the same order will occur a bug.

`RelNode planAfter = LoptOptimizeJoinRule.INSTANCE.onMatch(planAfter);` This line of code in test doesn't work, no definition of `planAfter`