Yanbo Liang comments

Results 51 comments of


                                            Yanbo Liang

str(weakref) throws error `KeyError: 'name'` if the original obj override getattr

@sobolevn Thanks for your quick response! I do agree this works well in functionality's perspective, but I'd like to say if this is a good user experience. If users are...

str(weakref) throws error `KeyError: 'name'` if the original obj override getattr

I can understand your point, if other parts of CPython do the same way, it's fine. But if you take a look at this example: ``` >>> class MyConfig(dict): ......

Add templated attention BLOCK_M & BLOCK_N default size for different head_dim

@pytorchbot merge

Dynamo doesn't log backward graphs in compilation metrics

> Backwards compilation is sometimes lazy. I recently added a structured_trace for AOTAutograd backwards compilation and we can also populate the scuba table with it too, although it must be...

[Dynamo] Support context wrapping(e.g, torch.no_grad) on nested functions w/o closure

@pytorchbot merge

[Dynamo] Supports if condition on user defined object

> Couldn't this change be a one line change to generic_jump that just checks if the VariableTracker is a UserDefinedObjectVariable and then you jump? Why are the other code changes...

[Dynamo] Supports if condition on user defined object

@pytorchbot merge

Cannot compile torchtext model

```typing._GenericAlias``` is type of ```typing.Mapping``` or similar ones, FX only supports basic data structure on the node right now. I hit similar issue, e.g, ```torch.storage``` is not supported on FX...

Expert parallelism / MoE example would be awesome :)

@andersonbcdefg We have added the support of Mixtral-8x7B MoE, please check https://github.com/pytorch-labs/gpt-fast/pull/71. Feel free to try and share feedback.

[Dynamo] Fix guards for script_if_tracing or lru_cache fn with default args

@pytorchbot merge