yamashu comments

Results 16 comments of


                                            yamashu

Setting codimd on heroku buttons → self signed certificate error

@YaCpotato I'm seeing the same thing on heroku. I fixed it to `node 12.22.1`, where db migration has been successful, and this solved the problem.

feat(backend revision): add clean-up note revisions job

> Please rebase your branch to the latest version of develop to fix the CI. Thank you for letting me know. After rebase, the test seems to work now!

feat(backend revision): add clean-up note revisions job

> However when deleting old revisions, we need to somehow compensate the missing information, don't we? A revision holds the diff (called patch in the entity) to its preceding revision....

feat(backend revision): add clean-up note revisions job

@ErikMichelson I have implemented updating patch (content diff), so could you please review it again?

fix(frontend): improves button's visibility and operability on the aliases modal

As in the case below, CI doesn't seem to work. https://github.com/hedgedoc/hedgedoc/pull/5345#issuecomment-1888628772 The tests have completed successfully in my local machine, but is there anything else I should do? # frontend...

fix(frontend): improves button's visibility and operability on the aliases modal

Thanks for your test!! > As I can't reproduce this on current develop branch, this seems to be a regression in this PR. Really? Sorry, I thought it was a...

fix(frontend): improves button's visibility and operability on the aliases modal

> Please rebase your branch to the latest version of develop to fix the CI. Thank you for letting me know 😄 After rebase, the test seems to work now!...

fix(frontend): improves button's visibility and operability on the aliases modal

> But maybe uploading the test results isn't working properly? It seems like this PR broke it. - #5379 I'll fix it.

chore(backend): Add timer berfore deleting realtime note

@ErikMichelson Thank you for your fixing 🙏 🙏 🙏

test(backend): complete the remaining test TODO on HistoryService

@InnayTool Please give me a review when you have time 🙏