YahyaAouledAmer

Results 22 comments of YahyaAouledAmer

Any updates on this PR? it will be so helpful to support the Ceedling 1.0.0

Modbus is a client/server data communications protocol in the application layer, used mainly in industrial automation. It is basically for reading and writing register values in the server. The Frame...

@Dimi1010 @seladb thank you for your comments @Dimi1010, for your last explanation, is "**PDUType**" a struct for a public PDU type? so, we need to define a different struct for...

@Dimi1010 thank you for the detailed explanation, it makes it much clearer. For the pull request, do you suggest I should update it continuously with my progress? Or submit after...

@seladb i think i can start Is there any code style i need to figure follow? Or doxygen documentation needed?

@seladb thanks I'll let you know with any update

@seladb I've prepared only 1 constructor which initiates the layer with default fields values Can you please mention what are the other constructors I need to implement? also please mention...

Hi @seladb can you please guide me briefly on how to add tests for my ModbusLayer for parsing/crafting headers? As I want to pass to function types request/response after testing...

@seladb I'll add tests for the headers crafting/parsing implementation and then you can a review before we move to adding the different PDU types

@seladb @Dimi1010 I've started adding some tests, but I have a question regarding the ".dat" files; how can I generate examples for some Modbus frames?