Timo

icon location Germany

Results 170 comments of Timo

Warn on any panic code like `unwrap`, `expect`, `assert`, `todo`, ...

There's been some discussion for what this should look like in #11808. > arithmetic wrapping (or maybe it should be caught too somehow?) [`arithmetic_side_effects`](https://rust-lang.github.io/rust-clippy/master/index.html#/arithmetic_side_effects) should do this

`redundant_async_block` not catching uses with nontrivial futures

They are semantically different if the expression has side effects. `async { some_function().await }` only executes the function call on the first poll, whereas `some_function()` eagerly calls the function. `ready`...

Remove `is_normalizable`

Why does `layout_of` (supposedly?) ice when normalization fails anyway? `LayoutError` has a `NormalizationFailure` variant and it seems to be [handling the case](https://github.com/rust-lang/rust/blob/42198bf562b548015e3eae3926c175c4aabb3a7b/compiler/rustc_ty_utils/src/layout.rs#L47) where normalization fails? Or am I missing something/is...

Avoid reported unsoundness for implied lifetime bounds

> I tried testing both together with a .fixed file, but that won't work with two lints in opposite directions. The situation is unusual, and in case it is preferred...

assigning_clones: Suggestion conflicts with borrow checker

I think for this we should be able to use [`PossibleBorrowerMap`](https://doc.rust-lang.org/stable/nightly-rustc/clippy_utils/mir/struct.PossibleBorrowerMap.html). That can tell us that `first` borrows from `name` and we can safely bail out if so. I've been...

Check for try blocks in `question_mark` more consistently

(Rebased.)

`?` error propagation lint breaks with try-blocks

There are no try blocks in the reproducer, but I assume what you meant is something like ```rs fn returns_option() -> Option { let _: Option = try { let...

Detect needless use of `let else` with trailing semicolon

This lint already exists ([question_mark](https://rust-lang.github.io/rust-clippy/master/index.html#/question_mark)), but it only seems to emit a warning for `else { return None };` (note the lack of a semicolon for the return), so this...

needless_borrow false positive in case when compiler does not automatically borrow

This issue seems to be fixed. None of the reproducers mentioned here get linted anymore it looks like: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3c4b7032d2e1c46d488b42a1a5cc4627

Use of a = b.clone() instead of a.clone_from(&b)

This was implemented in #12077 Output for the example ``` warning: assigning the result of `Clone::clone()` may be inefficient --> src/main.rs:5:5 | 5 | a = b.clone(); | ^^^^^^^^^^^^^ help:...