Timo
Timo
Thanks for reviewing, I'll address the comments eventually, but I will be busy for a couple more weeks, so it might take a while.
I created an FCP thread on zulip for this. Will squash when that's complete.
Changed the version atribute to 1.80 and rebased to fix conflicts + squashed. (had to force push twice since the first commit still had the old lint name in its...
I've been looking at `single_call_fn` specifically. It's doing [another pass through the whole crate at the very end](https://github.com/rust-lang/rust-clippy/blob/99423e8b30a5837adec3b987beb2099b432af007/clippy_lints/src/single_call_fn.rs#L84-L89) which doesn't seem necessary. We should be able to do what the...
Right, I see now. I think I initially tested it with a slightly different repro `type V = HashMap;` which didn't ICE despite a normalization failure and no compile error,...
Looks good to me! Initially had some concerns with the `is_zst` recursion possibly running into stack overflows on recursive types, but I convinced myself this is fine since this properly...
I assume you mean specifically `is_min_const_fn` could just return a bool, right? Returning a result in the private fns would still be useful since it allows using `?` everywhere (could...
I was trying to clean some of the error stuff up but found that the error reason strings seemed useful (even just for documentation purposes, maybe they should be comments),...
Hi. Yeah, I've been meaning to do this for a while (making nodes mutable), but I never really got to it because I didn't know if it was needed and...
My initial idea was to change `Bytes` (struct that holds substrings) to something like: ```diff --- a/src/bytes.rs +++ b/src/bytes.rs @@ -3,7 +3,12 @@ use std::borrow::Cow; #[derive(PartialEq, Eq, PartialOrd, Ord, Hash,...