Xinhao Xu
Xinhao Xu
 main and decouple benchmark
https://github.com/Mergifyio requeue
> Which revision does this bug occur on? I found it in new Main branch yesterday
> > > Which revision does this bug occur on? > > > > > > I found it in new Main branch yesterday > > Do you have an...
> Would you mind adding some background of this PR? Why do we need to `upload all data to shared storage as a sstable`? I add the [issue link](https://github.com/singularity-data/risingwave/issues/4290)
> I think the code of shared-buffer and local-version is too complexed. we can not keep the uncommitted-data in both shared-buffer and local-version. It will confuse other developers. > >...
> > Our pin_epoch will return two epoch. We need to choose which epoch we need. > > Still doubtful about this. :( So do we want to support different...
> I am a bit concerned with a 2.3K LoC PR with zero test :( > > Is it possible to split it into smaller PRs and add some tests...
> > I am a bit concerned with a 2.3K LoC PR with zero test :( > > Is it possible to split it into smaller PRs and add some...
After spilit out the meta code. the pr is left with only the frontend code which is slightly more than 1k in addition to the tests, the pr can continue...