Reficul

Results 44 comments of Reficul

@atoato88 remove labels if `ignore` annotation is applied, does this solution ok for you?

> @xuzhenglun IMHO, labels set in `r.options.labelMaker` are quite important on some situations. e.g. Filter objects by those labels, ... > > @justinsb Any ideas which don't delete those labels?...

/assign @thockin HI, I kindly request your review of this code. This PR mark KEP-3668 as implemented, just like https://github.com/kubernetes/enhancements/issues/3668 mentioned.

/hold As https://github.com/kubernetes/enhancements/issues/3668#issuecomment-1742136398 said, this KEP will remain `implementable` status for now until the feature gates are removed in feature.

/unhold feature gate has been removed in https://github.com/kubernetes/kubernetes/pull/124738

> /ok-to-test > > some comments that need to be addressed, but overall is LGTM > > /assign @thockin Thanks for reviewing, I'll take a look and fix it right...