Ed Jung

Results 9 comments of Ed Jung

See the latest README on develop for how to support this. It should be possible with something like: ``` def is_failure(thrown_type, thrown_value): return not issubclass(thrown_type, HTTPError) and issubclass(thrown_type, Exception) @circuit(expected_exception=is_failure)...

Here's a step-by-step tutorial for kind based on these comments https://github.com/knative/docs/pull/4948

I think I understand what happens with the probes and probe re-writes now (it's a startup optimization). It would be good to document for users because it's not obvious that...

> ... optimizations that we have in the activator to completely bypass the readiness signals and just probe the container on our own and send traffic to it ASAP (without...

Theoretically I think it could but this would require confirmation. A Deployment could have a low ephemeral storage limit, and the Pods would probably end up flailing. I did find...

There is a [comment](https://github.com/knative/serving/issues/13041#issuecomment-1174704850 ) in #13401 that saw similar behavior, but due to reasons other than ephemeral storage. There is an outstanding [KEP-3322](https://github.com/kubernetes/enhancements/pull/3339) that adds a `maxRestartTimes` to the...

That will only work for Kourier, and is even more complex than the documented way of setting the default. The request is to make the default value "svc.cluster.local" as the...

I am able to make this work in our Knative installation using Istio Ingress. Unfortunately we have two different clusters with customized installations, so I couldn't tell you what the...

The way the requirements files are being used has a couple other problems. They are not really supposed to be read and parsed into `setup.py`. Moving it into `test-requirements.txt` still...