Miroslav Suchý

Results 287 comments of Miroslav Suchý

I think you want to use https://github.com/rspeer/ordered-set which is actively developed.

I noticed that appstream-builder is checking *src.rpm - is this usable at all? BTW This is the command we (as Copr) run: ``` /usr/bin/appstream-builder --temp-dir=/var/tmp/appstream-reproducer/fedora-rawhide-x86_64/tmp --cache-dir=/var/tmp/appstream-reproducer/fedora-rawhide-x86_64/cache --packages-dir=/var/tmp/appstream-reproducer/fedora-rawhide-x86_64 --output-dir=/var/tmp/appstream-reproducer/fedora-rawhide-x86_64/appdata --basename=appstream --include-failed...

I just got a nice reproducer. I have a directory with only one rpm and this command: ``` time /usr/bin/appstream-builder --temp-dir=/var/lib/copr/public_html/results/greghellings/intellij-idea/epel-7-x86_64/tmp --cache-dir=/var/lib/copr/public_html/results/greghellings/intellij-idea/epel-7-x86_64/cache --packages-dir=/var/lib/copr/public_html/results/greghellings/intellij-idea/epel-7-x86_64 --output-dir=/var/lib/copr/public_html/results/greghellings/intellij-idea/epel-7-x86_64/appdata --basename=appstream --include-failed --min-icon-size=48 --veto-ignore=missing-parents --enable-hidpi --origin=greghellings/intellij-idea...

It took me some time :) , but here are the requested data. http://miroslav.suchy.cz/tmp/callgrind.out.1239841 This is the output of ``` valgrind --tool=callgrind /usr/bin/appstream-builder --temp-dir=/tmp --cache-dir=./cache --packages-dir=. --output-dir=./appdata --basename=appstream --include-failed --min-icon-size=48...

This patch is actually in package in Fedora Linux for ages. No issue has been reported during that time.

The other option can be: ``` try: from ordered_set import OrderedSet except ImportError: from marshmallow.orderedset import OrderedSet ```

Can we rename glacier.py to glacier-cli.py?

> It doesn't matter which of the two is updated first - there will be an inevitable period of breakage. You can have symlink one to the other during transition...

rebased to current master

Addressing your comments (after long pause): 1. you can not use sys.getdefaultencoding(), because that return 'ascii' and it will cause ``` >>> a='ýíáží' >>> a.decode('ascii') Traceback (most recent call last):...