Ang Li comments

Results 55 comments of


                                            Ang Li

Majority pass tests

We actually considered this feature before and decided against it. Maybe the circumstances have changed. Let's discuss offline.

Instrumentation check fails on some devices

1. this error is not exposed today, bc the adb cmd ret code 0 so it's treated the same as the package is not instrumented. 2. adding nobs for such...

Instrumentation check fails on some devices

A retry does not mask that exception though. It'll still throw if the device actually crashed etc. This is a pretty standard way to get around adb flakiness in systems...

Instrumentation check fails on some devices

This is not a high priority thing though as it rarely happens...

Instrumentation check fails on some devices

Perhaps we could in addition throw a better error for such cases. E.g. if there are lines (except for the first line) that don't start with "^instrumentation:", throw an error...

Make the log level to stdout customizable

Flag meaning? This is just to be consistent with how LogPath is set.

Make the log level to stdout customizable

Only affects stdout as the title says... Not sure how useful this is though On Jul 31, 2017 8:13 PM, "David T.H. Kao" wrote: > I had meant a command...

Short adb calls made by `AndroidDevice` controller should have timeouts

#556

Always create the `AndroidDevice` object specific log directory.

Windows CI is broken. Need to fix

Always create the `AndroidDevice` object specific log directory.

This is ready for review