Xavier Lecours
Xavier Lecours
I think I found write operations on $_SESSION['State'] that occur after session_write_close 1. https://github.com/aces/Loris/blob/c38f1c1ea4bef8112882e0bf48c81a1c13337fc3/php/libraries/NDB_Menu_Filter.class.inc#L324 2. https://github.com/aces/Loris/blob/c38f1c1ea4bef8112882e0bf48c81a1c13337fc3/php/libraries/NDB_Menu_Filter.class.inc#L332
All candidates that don't have a session also don't show in the sex breakdown.
This is untestable within the time window allocated to testing v.24
TODO - [x] Update testPlan - [ ] Update Automated tests @xlecours to create issues
@ridz1208 - testplan updates : https://github.com/aces/Loris/issues/7660 - Update Automated tests: no. testAllLinks() is still missing the last 5 "links".
@driusan, what are the changes requested? I only see questions and a suggestion.
@driusan `Remove WindowDifference` why? this is a property of a subproject.
@driusan `Possibly remove RecruitmentTarget` something like the dashboard could use that to create the chart.
@driusan I have removed `SubprojectID`, `WindowDifference` and `RecruitmentTarget ` in the subproject details. The `/subprojects` endpoint now returns an array of title+link. Having the details in a single endpoint obfuscate...
``` -- There was 1 failure: 1) NextStageTestIntegrationTest::testNextStageDoespageLoad Failed asserting that [] contains "Next Stage". /app/modules/next_stage/test/next_stageTest.php:46 ``` restarting jobs