xkns

Results 7 comments of xkns

I have used such _dominant color extraction_ in the past and found that many implementations are based on a [javascript implementation called Color Thief](https://github.com/lokesh/color-thief). They also have a [live web...

> This pull request **introduces 5 alerts** when merging [b874453](https://github.com/hyperion-project/hyperion.ng/commit/b8744535557117ebc9ace83fb9bb1dd6202451d6) into [359618a](https://github.com/hyperion-project/hyperion.ng/commit/359618a4eefd4fc4a27d49993d9960e8f896c544) - [view on LGTM.com](https://lgtm.com/projects/g/hyperion-project/hyperion.ng/rev/pr-de484607add39959ac3de47b66f8d5cbe502d5bf) > > **new alerts:** > > * 4 for Multiplication result converted to larger...

> I deeply hope that this PR is accepted. I compiled this and the saturation and brightness gain controls put Hyperion over the line for me. I've been in contact...

Edit: Sorry I misunderstood what you were saying. You're talking about the color setpoint settings and not that certain input colors go missing at some point. The Okhsv transform is...

> a) As I am not too detailed in the Color transformation subject, maybe you could help me in understanding why the saturation and value gain are transformed before the...

> @xkns Ready to merge from your perspective? Yes ready to merge

Can confirm that it will also lawndart into the surface if that's cheaper than going the long way round.