Xin Hao Zhang
Xin Hao Zhang
https://www.loom.com/share/9a3c1c9a62694a2d8f2061d748fda4d5 Since I couldn't connect as a user to run queries, it's just showing here the network request being made (and not being made on serverless). The time spent waiting...
TFTR!!! bors r+
blathers backport 22.2
Yes, that behaviour is still preserved here, we're doing the exact same thing but in the component state instead of redux since this info isn't needed anywhere else in the...
This PR undoes the proper object construction from local settings that existed in `globalTimeScale.ts`. This means if a user refreshes the page and we construct the timescale from session storage,...
Going to take a stab at this since it will be useful for testing https://github.com/cockroachdb/cockroach/pull/119283 and some fingerprint changes.
*[`pkg/sql/conn_executor_exec.go` line 622 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/124250#-NyR0pEF5YS_H-veI_gq:-NyR3hFAA7iaOiK1am4f:b-y1sahw) ([raw file](https://github.com/cockroachdb/cockroach/blob/ccddd4145b7ad216fbabef9f501a76099896a207/pkg/sql/conn_executor_exec.go#L622)):* Previously, abarganier (Alex Barganier) wrote… Just confirming - the fingerprint will still be recomputed further down in the `maybeLogStatement` call for this scenario,...
TFTR! bors r=abarganier
*[`pkg/sql/conn_executor_exec.go` line 853 at r4](https://reviewable.io/reviews/cockroachdb/cockroach/124371#-NyQiV-wCPf-P9erdetj:-Nyf9IV33VAmdY9cmVIY:b-3yktgl) ([raw file](https://github.com/cockroachdb/cockroach/blob/58d99cdb2a91bad286914de030c83aa4a7882a39/pkg/sql/conn_executor_exec.go#L853)):* Previously, rafiss (Rafi Shamim) wrote… on the main issue, i had a similar instinct: https://github.com/cockroachdb/cockroach/issues/122722#issuecomment-2073150240 i feel like it would be less disruptive,...