Shane Xie

Results 30 comments of Shane Xie

> what contexts is it appropriate for an application such as CoreDNS to create Events. IMHO, Events are structured logs to convey an explicit message, they are often used to...

> They are intended for human consumption. @johnbelamaric Thanks for clarifying this. Maybe they do not have a choice when metrics/object status are not exported, anyway, they are on their...

Thanks @chrisohaver for following this. I've added the unit test part in https://github.com/xh4n3/k8s_event/pull/3 . Please let me know if that's okay to merge.

@chrisohaver Thanks for reviewing the pr, the unit test part is merged now. Next we should begin transferring the ownership, what should I do?

Thank you @yongtang for creating the repo 😃 > It should be easier to just transfer the repo... The transfering failed with `coredns/k8s_event already exists` so I guess I have...

Yeah, the new repo looks good now. Thank you @chrisohaver So the next thing to do would be updating the coredns/coredns.io, right?

@chrisohaver I opened two PR, [one](https://github.com/coredns/coredns.io/pull/272) adds the plugin documentation, [one](https://github.com/coredns/k8s_event/pull/1) fixes the repo path in the new repo. Please help me review them, thanks!

Helm v2 uses `HELM_PLUGIN` as plugin directory environment(https://github.com/helm/helm/blob/release-2.14/pkg/plugin/plugin.go#L181), while Helm v3 uses `HELM_PLUGINS`(https://github.com/helm/helm/blob/release-3.0/pkg/cli/environment.go#L66). This is causing `https://github.com/chartmuseum/helm-push/blob/master/pkg/helm/repo.go#L35` cannot find plugins since no plugin is registered.

@jdolitsky hi, may i know if you have plans on this provenance support? Or are we supposed to wait for helm v3? Thanks!

> we cannot upgrade to CoreDNS to higher version than 1.8.4 @dpasiukevich is it because the newer CoreDNS is relying on some vendors which conflict with skydns'?