Xav Paice
Xav Paice
rebased against current main branch
IIUC, this change is effective for k8s 1.21? Wonder if we can split out the content of addons/prometheus/0.55.0-34.10.0 from the change to templates & patches, and have a separate commit...
Adding the symlink to upgrade-charm did indeed fix this - this probably is a charm template/doc issue then?
Function `Logs()` uses `ctx := context.Background()` as the context for log collection. This should be reconsidered, maybe use `WithTimeout` instead, maybe like the docs example: ``` const timeout = 60...
This contains a change to text_analyze.go which could still be relevant and is not currently implemented, but due to the discussion in this PR plus the need to rebase and...
There's been some discussion around whether it's better to use the `--namespace` flag to restrict to a namespace, and default to all namespaces if not specified, or if Troubleshoot should...
@markpundsack recent work has allowed us to have multiple specs supplied to Troubleshoot, but at this point we have shied away from installing the CRDs in the cluster and storing...
This issue is >2 years old at this point, and I just tested and could not reproduce. I'll close it out, other changes have probably mopped this up.
The first two bulletpoints are already done as per what's already in main - we just didn't know till Edgar found it there. The second two look like they need...