Xavier Lozano Carreras
Xavier Lozano Carreras
PR ready for review: D159347-code
> @xavier-lc, since not all a12s have access to Phabricator, could you please come back and close this issue once the patch is merged? Thank you! Yes, I'll do that...
The review is taking a while :/ I think it'll get aproved soon, though.
@mrfoxtalbot the changes have been deployed.
@mrfoxtalbot hey, sorry for the late reply, I was AFK last week. @epeicher are you working on this? If not, I can take over.
> We have fixed a similar error in another screen by using the function [openLinksInParentFrame](https://github.com/Automattic/wp-calypso/blob/61ec712d83c853cc931ba925536445c79413fd39/apps/wpcom-block-editor/src/calypso/features/iframe-bridge-server.js#L544C16-L544C38). See #83472 Thanks for sharing. I don't think it works in this case, though, because...
I've got this working locally, but the docker build is failing: ``` 16:56:03 > [builder 5/9] RUN yarn install --immutable --check-cache --inline-builds: 16:56:03 1.313 ➤ YN0000: ┌ Resolution step 16:56:03...
> I created a PR in Gutenberg to upgrade Redux to v5.0.1, it's one of things that could help: [WordPress/gutenberg#66966](https://github.com/WordPress/gutenberg/pull/66966) Awesome, @jsnajdr. Thanks!
Even after updating `@wordpress/data` to `10.11` the docker image build is stuck, even if there's no dependency left on redux v4. So I recreated the PR from scratch on https://github.com/Automattic/wp-calypso/pull/96403,...
> I tried to test with the other client id but I end up on an error page Thanks for the catch, there was a js error that I've fixed...