xareyli comments

Results 11 comments of


                                            xareyli

HTML entities not properly handled in link previews

Please review https://github.com/RocketChat/Rocket.Chat/pull/27371

[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option

@hugocostadev please review

[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option

I haven't faced any issues with this. Through logging I have figured out that lack of initial value for `muteGroupMentions` causes the bug (https://github.com/RocketChat/Rocket.Chat/issues/27512). Initially `muteGroupMentions` is undefined. When user...

[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option

I had a little research on this. Here we define the `muteGroupMentions` as `undefined`, which then will be tried to cast to `boolean`, which leads to `muteGroupMentions` is defined with...

[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option

@debdutdeb @hugocostadev please review. Think this should work

[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option

@debdutdeb @hugocostadev if you have spare time, please review

Grammarly not working

Is that a feature request?

[FIX] : Notification Preference Save Button Update

@dudanogueira Can be closed due to done https://github.com/RocketChat/Rocket.Chat/pull/27513

Regression: Bad words Filtering not working on new Message Parser

Glad to help ;)

Badwords Filtering not working on new Message Parser

Oh, it seems that there is an assigned developer for this issue. @dudanogueira Should I notify that I'm working on an issue before creating PR? P.S. Review https://github.com/RocketChat/Rocket.Chat/pull/27368