TillW

Results 10 comments of TillW

Make `Numerics` class internal

I am happy to make the proposed change. @stevenaw, can you assign this to me?

Make `Numerics` class internal

Both PRs are merged. Since this issue is still open, I wonder if there is any work left?

ANSI Escape code is being escaped.

I would like to take this issue. @bradwilson, can you please assign it to me?

ANSI Escape code is being escaped.

It took some time until I got familiar with the codebase. @bradwilson, can you please check if my assumptions are valid? 1. The `main` branch is the baseline of the...

ANSI Escape code is being escaped.

Yes, I think the console-runner (who is aware of the _nocolor_-setting) is the right place. I'm still wondering which is the best solution for handling ANSI-escapes. As for now, I...

ANSI Escape code is being escaped.

I will go for option C

ANSI Escape code is being escaped.

The `TestOutputHelper` now does not escape the `ESC` of an [ANSI-SGR sequence](https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters). The `ConsoleRunnerLogger` now removes all ANSI-SGR sequences when `-nocolor` is `true`. But I found another implementation of `IRunnerLogger`,...

ANSI Escape code is being escaped.

@bradwilson: Thank you for highlighting the problem with semicolon-separated attributes. I overlooked this possibility in the Wikipedia article. When I read it again, I saw that arguments may also be...

How to check for system members?

I would also like to implement a test that only certain types can access the system time. However, the solution mentioned by @simonthum unfortunately does not work for me. I...

How to check for system members?

I was wrong -- Properties are a C# feature which are transformed into methods by the compiler. After specifying an empty parameter list and adding the assembly of `DateTimeOffset` to...