x12301450

Results 4 issues of x12301450

In CMakeLists.txt, DEB_PYTHON_BUILD_DIR is defined as follow with a trailing slash: `set(DEB_PYTHON_BUILD_DIR "${CMAKE_SOURCE_DIR}/bindings/python/")` But you use this variable like this: `set(DEB_PYTHON_OUTPUT_FILE_PREFIX "${DEB_PYTHON_BUILD_DIR}/dist")` It has double slash after concat of DEB_PYTHON_BUILD_DIR...

In mlir/lib/Target/LLVM/CMakeLists.txt, the variable `CUDAToolkit_LIBRARY_ROOT` is used in the following way in Line 66: `set(MLIR_CUDAToolkit_ROOT ${CUDAToolkit_LIBRARY_ROOT})` and like this in Line 135: ``` find_file(MLIR_NVVM_LIBDEVICE_PATH libdevice.10.bc PATHS ${CUDAToolkit_LIBRARY_ROOT} PATH_SUFFIXES "nvvm/libdevice" NO_DEFAULT_PATH...

cmake

In CMakeLists.txt, there are three calls of `add_string_config`, for example: ``` add_string_config(${SC_CONFIG_GROUP} DEFAULT_SERVICE_MANIFEST_DIR "${SYS_CONFIG_DIR}/service-manifest.default.d/" "${SYS_CONFIG_DIR}/service-manifest.default.d/") ``` However, variable `SYS_CONFIG_DIR` is defined with a trailing slash, leading to double slash issue...

在dnn/CMakeLists.txt中,变量OPR_PARAM_DEFS_OUT_DIR被定义为: `set(OPR_PARAM_DEFS_OUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/include/)` 在接下来使用的时候,所有的变量后面都加上了一个额外的 ‘/’,例如: `${OPR_PARAM_DEFS_OUT_DIR}/megdnn/opr_param_defs.h` 虽然这暂时不会导致报错,但是我认为可以将OPR_PARAM_DEFS_OUT_DIR的定义改为: `set(OPR_PARAM_DEFS_OUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)` 从而解决这个问题,提升CMake代码的质量。希望能够帮助到你们。