Wing Yew Poon
Wing Yew Poon
CI completed and passed. I don't know why the status did not get updated here. @mgaido91 @jerryshao can you please review?
@mgaido I explained the issue in the description of [https://issues.apache.org/jira/browse/LIVY-771](url). I also just called out in comments on the code what the problem is. To repeat myself, if you have...
I updated the Jira as well as the PR description to point out that the BigDecimal values returned in JDBC can be incorrect due to this bug.
Hi @mgaido91 , I have responded to your point about negative scale in the decimal type in Spark SQL, and addressed the nit about the comment in the ColumnBufferTest. I...
@mgaido91 I think this is an important bug, and the fix is straightforward. I think I have provided an adequate test. I do not plan to spend any more time...
See https://github.com/apache/incubator-livy/pull/275/commits/29114951c48d3d1829d4a0fdaaa338983e193caf for my fix to the python-api CI failure.
@RussellSpitzer were you the original author of the migrate action (#1525)? Was the purpose of the backup table simply for restoring it in case the migrate failed? If so, it...
@rdblue can you please point me to the doc with a step to remove the backup table? I do not see it in https://iceberg.apache.org/docs/latest/spark-procedures/#migrate.
I understand the thinking behind keeping the backup table after a successful migrate action and having the user decide what to do with it. If somehow this isn't already documented,...
@aokolnychyi please look. Also, if you don't mind, I'd like to change `estimatedRowsCount` to `estimatedRowCount`, as that is more idiomatic. Row count is the count of rows. If you agree,...