Wil Wilsman
Wil Wilsman
I'm betting it has something to do with the `innerHTML` property. That property parses the html. I think what we'll want is `textContent`. There's a few places we reference `innerHTML`...
Hey @benedfit! I wouldn't expect the changes made to effect lazy loaded images, because in both versions we only wait for network idle (we don't do any scrolling or event...
Hey @benedfit! When setting `enableJavaScript: true`, it will actually skip taking a DOM snapshot of the story and instead use the raw preview.html contents. As for missing assets, [this doc...
Hey @flexyford! Sorry it took me so long to get around to looking at this! So the problem is actually not that the array is the wrong length, but that...
Mind telling me what browser you're using? Works fine for me in the latest Chrome.
Having shard options like that would be a great addition! I'll see if we can slot it in with some upcoming work on that command.
Regarding the 35 minutes though, that does seem like a while for this command. Looking at your logs, I see that the time includes downloading Chromium which happens the first...
> ideally Percy would just offer a Docker image with this included There already exists plenty of docker images with browsers included and since Percy is typically a project dependency,...
For your Docker image, I personally like CircleCI's docker images. My go to is typically [`circleci/node:lts-browsers`](https://hub.docker.com/r/circleci/node) which comes with a few other browsers too (useful for cross browser testing). I...
Hey @mitar! We just noticed a bug actually with our 422 errors where details aren't included in the response. So the debug logs likely wouldn't help. The likely cause is...