Piyush Kumar

Results 8 comments of Piyush Kumar

Maybe I should explain. The reason I changed the functions (which were not actually used) was because I was unsure of which way to solve the issue. On one hand,...

> create coverage report in the cont_integration jobs itself to get coverage for the full test suit.. I actually tried that, but I couldn't get the reports from the separate...

> In the last dev call we converged on approach of > > * Update the existing coverage tool from codecov to better stuffs. > > * Make the coverage...

> With this PR looks like codecov report shows 90.87% coverage 🥇! > > https://app.codecov.io/gh/wszdexdrf/bdk > > Old config only showing 77.21%: > > https://app.codecov.io/gh/bitcoindevkit/bdk I hate to say this,...

> I just noticed on coveralls that it doesn't show the source code so there's no way to see what lines are covered or not, is there something you need...

Maybe I could work on this.

I have reached a small hiccup. I was going to get blocktimes (for median time past) from the `blockchain` object, but then realised there is no way of actually accessing...

> I'm wondering whether "Hardware Wallet" is the best name since we have a struct named `Wallet` Now that you say it, it makes sense. This isn't anywhere close to...