Henddher Pedroza

Thank you @pmaupin I will continue to investigate and share here what I found with the hope that a second pair of eyes and good understanding of the PDF spec...

Hello @pmaupin I implemented 3 PNG filters: Up(2), Average (3) and Paeth (4). I am not sure but I think the existing Sub filter implementation might have been used as...

Thanks @pmaupin Indeed! I hope this addition will move it closer. I'll try the static PDFs and see what happens.

@pmaupin I am having issues running the test-cases ... ``` Ran 437 tests in 62.324s FAILED (SKIP=56, errors=49, failures=4) ``` I did this: ```bash $ cd pdfrw/tests $ git clone...

Thank you @pmaupin That did it! (`python -m unittest` didn't work for me but `pytest` did) ```bash $ pwd /Users/henddher/Documents/python_workspace/pdfrw_playground/pdfrw/tests $ ln -s ../pdfrw $ ls -l pdfrw lrwxr-xr-x 1...

Here is one of the failures: ``` test_examples.py .......F >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> self = def test_rl1_4up(self): if sys.version_info < (2, 7): return self.do_test('rl1/4up b1c400de699af29ea3f1983bb26870ab', > scrub=True) ../../../test_examples.py:171: _ _ _...

That was it! I didn't know `reportlab` was required. I `pip`ed it and now `master` branch passes all tests. I will add these notes to the README.md test part. Thanks...

Back in my branch, I've got 10 failures - which is *good* because I did change code :P ``` # Failures TestOnePdf.test_compress_2ac7c68e26a8ef797aead15e4875cc6d.pdf TestOnePdf.test_compress_35df0b8cff4afec0c08f08c6a5bc9857.pdf TestOnePdf.test_compress_9f98322c243fe67726d56ccfa8e0885b.pdf TestOnePdf.test_decompress_2ac7c68e26a8ef797aead15e4875cc6d.pdf TestOnePdf.test_decompress_35df0b8cff4afec0c08f08c6a5bc9857.pdf TestOnePdf.test_decompress_9f98322c243fe67726d56ccfa8e0885b.pdf TestOnePdf.test_repaginate_2ac7c68e26a8ef797aead15e4875cc6d.pdf TestOnePdf.test_repaginate_35df0b8cff4afec0c08f08c6a5bc9857.pdf TestOnePdf.test_simple_2ac7c68e26a8ef797aead15e4875cc6d.pdf...

No dice :( I tried running all `test_roundtrip` cases with breakpoint at `pdfrw/uncompress:32` ```diff diff --git a/tests/test_roundtrip.py b/tests/test_roundtrip.py index a8349a6..c878101 100755 --- a/tests/test_roundtrip.py +++ b/tests/test_roundtrip.py @@ -109,6 +109,7 @@ class...

Bingo. You are correct about the `subprocess`. I added the breakpoint to `uncompress` and I am about to `pdb` it :) I'll look at #98 changes. I assume you mean...