Daniel Wrigley

Results 25 comments of Daniel Wrigley

PR created to extend the docs: https://github.com/o19s/elasticsearch-learning-to-rank/pull/477

PR [477](https://github.com/o19s/elasticsearch-learning-to-rank/pull/477) merged into master, closing this issue

issue resolved with #513

Thanks for the contribution @cdmbr and thanks for your patience.

Summary of our chat at Haystack: * Rename the parser to `model/xgboost+json+raw` * Add the switch-case for the additional model parser * Preserve existing functionality * Add tests * Documentation...

> @wrigleyDan a small correction: shall we rename it to `model/xgboost+json+raw` instead of v2? Thanks, copied the old name and forgot to change it. Well spotted, corrected it in the...

Thanks for making the changes so quickly @pltb! There are a couple of tasks failing when executing the tests around checkStyle: ``` > Task :checkstyleTest [ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:56: Line is...

Thanks for the contribution and thanks for your patience @pltb Merging this into main. I will create two follow-up tasks: * in this repo one to add documentation for this...

I assume the response is something Splainer doesn't expect but I did not have any time doing further analysis. I'll have a closer look when I can give this some...

Further digging shows that the automatically added parameter `"profile": true` causes OpenSearch to throw an error. This may point towards OpenSearch's Profile API currently not yet supporting hybrid search queries....