Liang Ma
Liang Ma
Thanks @rahul-malik! Very good points. #1, yep, either subset of or full json-schema spec is a good idea; #2, I don't think we need inheritance in Plank at all. JSON...
i thought you said that xchammer version was broken in your m1-sim branch? Since xchammer is used in both non-M1 and M1 builds, I'd like to do incremental cherry-picks and...
> they seem to be and most of them are resolved by https://github.com/pinterest/xchammer/pull/290, but not entirely fixed.
Potential limit w/ this approach is: this EM logic has to be via an okhttp app interceptor as network interceptor would not allow short-circuiting. This might be fine for apps...
I was using app interceptor as well :) just wanted to point out that people would need to migrate their own network interceptors or anything relies on those built-in interceptors(retry,...
Another limit with app interceptor is that people often do baseOkHttpClient.newBuild().addInterceptor(their_new interceptor_for_their_okhttpclient).build() so they would need to make sure Evnoy interceptor is the last one, so it has to be...
i agree forking okhttp is bad