woshikid

Results 29 comments of woshikid

I found the existing test already covered the case that profile with file extensions, so I didn't add new one. ```java @ParameterizedTest @ValueSource(strings = { "yml", "yaml", "json", "properties" })...

I spend some time on this issue and don't think this is a bug. The method `containsBranch` in class `JGitEnvironmentRepository` do have small problem dealing with branch name contains slashes...

I have some misunderstanding on this issue. Let me look into it later.

You are right. This bug do causes problem when using tags. I agree with you. As you mentioned, the key point to this bug is the code `ref.getName().endsWith("/" + label)`....

@ryanjbaxter I've made a PR #2147 , please take a look

In spring-cloud-config-server:3.1.0 org.springframework.cloud.config.server.environment.EnvironmentController has `@GetMapping(path = "/{name}/{profiles:.*[^-].*}", produces = MediaType.APPLICATION_JSON_VALUE)` I think that's the regex caused the problem. I guess it want to exclude the pattern `{application}-{profile}.properties` but `.*[^-].*` still...

The direct reason causes these failures is in `EnvironmentCleaner#clean` ```java public Environment clean(Environment value, String workingDir, String uri) { Environment result = new Environment(value); for (PropertySource source : value.getPropertySources()) {...

the workingDir is in URI format ```java // AbstractScmEnvironmentRepository#findOne return this.cleaner.clean(result, getWorkingDirectory().toURI().toString(), getUri()); ``` but `PropertySource`'s name is in windows path format ```java // StandardConfigDataResource @Override public String toString() {...

It is fixed by later release, just need to simplify

I use Spring cloud version 2021.0.1 too, I can't reproduce this issue because include fails on Git backend too. It throws `org.springframework.boot.context.config.InvalidConfigDataPropertyException: Property 'spring.profiles.include' imported from location xxxxx`. There's a...