Wesley Oldaker

Results 19 comments of Wesley Oldaker

This has been driving me crazy for weeks. Adding "vim.startofline": false, "vim.foldfix": true to my .vscode/settings.json file fixed it. No restart required. Thank you!

I am getting the same thing. Incognito or otherwise, the result is the same. I first clicked on .NET to change the flavor. That went fine. But then, as soon...

I can create a PR for it, sure, but it would have to wait until this weekend. On Thu, Dec 19, 2024, 8:26 AM ST-DDT ***@***.***> wrote: > faker.finance.routingNumber >...

I am so sorry. I got busy and then completely forgot. It's the weekend, and I have time today. I'll do it now. On Sat, Mar 1, 2025 at 7:17 ...

A few questions for you: 1) From what I see in the code and from what I've read in the contribution guide, I am assuming that the static lookup data...

I've never actually submitted a PR in github before. I hope I did it right. [Here is the PR](https://github.com/faker-js/faker/pull/3429). @ST-DDT

Done. I used one of the routing numbers from the test snapshot for the example string.

Also, I forgot to mention... I couldn't figure out how to link [the original issue](https://github.com/faker-js/faker/issues/3290) to this PR. Sorry I am a bit new to contributing to public github repos.

Also, as I'm sure you've noticed, I skipped any form of testing whether the 2nd group of 2 digits at indexes 2-3 actually matched up with one of the numbers...

Strange. I keep getting this today: ![image](https://github.com/user-attachments/assets/f6b2b1bd-3f42-499b-8fa4-dbc2ecfab90f) which ultimately ends up failing the preflight: ![image](https://github.com/user-attachments/assets/5707ce01-ace4-49e1-8e4c-2a9e91c8ba05) When I first went to make the changes you had requested, pnpm complained about being...