Wojtek Jasiński comments

Repositories
Issues
Comments

Results 1 comments of


                                            Wojtek Jasiński

Potentially wrong number of argument in cumsum op

The third argument is optional. https://pytorch.org/docs/stable/generated/torch.cumsum.html It is treated as optional in torch.onnx: https://github.com/pytorch/pytorch/blob/e30c55ee527b40d67555464b9e402b4b7ce03737/torch/onnx/symbolic_opset11.py#L412-L424 and you guys actually not use the third argument here - you ignore it https://github.com/apple/coremltools/blob/8b7048ebc034a8b40e48c39df3f33ba9f60feda9/coremltools/converters/mil/frontend/torch/ops.py#L929-L936