William Kumler

Adding support for this feature in all joins, not just stringdist! Would be great for spatiotemporal data where the units of lat/lon and time are very different internally.

I don't have strong opinions on it, honestly! I agree that `chromPeaksQuality` is too ambitious unless this is a spot we want to allow others to calculate additional metrics from...

I like it! Sounds good to me.

Yeah, we struggled to find a lot of standardized "peak quality" definitions in the literature when working on the original project as well. The [Kantz 2019 paper](https://pubs.acs.org/doi/10.1021/acs.analchem.9b02983) uses six quality...

Hi Pete, Yeah, I figured! Was hoping to sneak in under the code freeze deadline but totally understandable that you'd like to give it more review time. I appreciate the...

I'm a regular R user so I'll contribute to this thread a bit more too - found this package from your [response on SO](https://stackoverflow.com/questions/63668589/cyclic-colormap-in-r) and struggled with the fancy RDS...

One more comment - it's not due to the dendrogram rendering either. We get the same result if we disable dendrogram things with `Rowv` and `Colv = FALSE`: ```r heatmaply_mat

Glad it's useful! The example you give above seems to maybe be a separate issue though, one relating to shiny not rendering more than 16 heatmap subplots no matter the...

Oof, yep. Can confirm it works fine for me under `plot_method="plotly"` but fails under `plot_method="ggplot"`. Good to know that I can just switch to the `plotly` option if necessary though,...

Hi @PeteHaitch, Thank you for the detailed review and thoughtful comments on the package! I have implemented essentially all of your recommendations but could use some advice on the last...