Jeff Winkler

Results 11 comments of Jeff Winkler

Going through this now. Actually really like in in my editor as code (https://twitter.com/winkler1/status/628643765050322944). Somehow the "feel" of reading code in IDE, with familiar code hilighting and careful line-by-line reading,...

Hey, thanks for the PR! Silly question - why freeze functions? With the JSON serialization/cloning, seems like they'll be stripped out- ![image](https://cloud.githubusercontent.com/assets/883896/9170435/c4321430-3f30-11e5-8aee-600d51decad1.png)

@aaronjensen Adding the null check and an explicit test, thanks. The Redux devtools make a point of saying to use serializable data structures for its time travel abilities. Will beef...

@aaronjensen re:enumerable - now that you mention it... non-enumerable props are stripped by JSON.stringify cloning, so Object.keys would work just as well. ![image](https://cloud.githubusercontent.com/assets/883896/9223485/78c2e1b6-40c8-11e5-9957-1ab6e711f3d4.png) I'll add a test to make this...

@awwright Any thoughts? The test is just there as a benchmark to demonstrate how much of a hotspot `url.resolve` is :)

That's better! Though for some reason, the pie slices don't get selected and show detail on click... This push also solves the mystery of where paths-js was coming from, was...

The tree also does not collapse/expand locally....

Your code is more elegant (functional components; recompose is interesting). This one has an example mutation...

oh...does it at the end. Totally unexpected. Tooltip on buttons would be good, IMO makes sense to insert after current selection.