Pieter du Preez
Pieter du Preez
Hi @sewenew, Thanks a lot. There's no rush, we're all humans ;) Regards
Hi @sewenew, Thanks for keeping me in the loop. I'll definitely look at the changes and give you feedback, however I would only be able to get to this in...
Hi @sewenew, I commented directly in 10ca2b2. >Also this commit adds a ttl method for RedLock, so that end user can easily get to know whether the lock has been...
Hi @sewenew, >Thanks for your comments! I created a new commit to fix your comments. You can take a look. This looks OK to me. One thing that I did...
Hi @sewenew, Thanks for the explanation. Here is some stuff that I picked up, while reviewing your last 2 commits (10ca2b2 and 10c333d): From: https://github.com/sewenew/redis-plus-plus/commit/10ca2b2b7faeb3a1e0f9df35904f7368243a9709#r35934763 > Yes, I mixed <...
Hi @sewenew, Thanks for your feedback. OK, I'll make another PR for this and I'll keep returning `-1ms`. Regards
Hi @sewenew, >OK, I'll make another PR for this and I'll keep returning -1ms. This is done in PR #39. Regards
Hi @sewenew, No problem. I'm glad PR #39 was usable. Please let me know if I could close this issue. I however think it will be good to keep it...
Hi @sewenew, I would like to send you some PRs for the recipes branch, but I saw it's a bit behind master. Would it be possible for you to merge...
Hi @sewenew I think the first post in this thread can be updated: >There're still many features we need to support. The following is a TODO list: Async interface. Issue...