Results 42 comments of Pieter du Preez

Hi @sewenew, >This looks like a hidden feature, since no document mentioned this deployment. The only problem is that we have to carefully configure the sentinel to have a longer...

Hi @sewenew No problem. I won't mind if you close this issue in order to reduce the issue-clutter. You could just add this to the TODO LIST (#74) issue. BTW,...

Hi @sewenew >RESET seems to be a new command, and I’ll do some research on it. Thanks for the info. You are right. According to the [Redis release notes](https://raw.githubusercontent.com/redis/redis/6.2/00-RELEASENOTES), it...

Hi @sewenew, Your suggestion sounds goo to me. However, I have a comment on point 4: > 4. Check if nodes info changes from time to time, if nodes info...

Hi @sewenew, I did a first throw at adding redlock support in #32. Regards

Hi @sewenew, Thanks a lot for looking at my PR #15, as well as your positive feedback. In the meantime, I fixed the bug that you found and added a...

Hi @sewenew, I reviewed a part of your commit 856ed96. Regards

@wingunder wrote: >I haven't made Redlock::lock() return std::chrono::milliseconds yet, as: > > 1. I'd really like to benchmark the lock-times, before investing time to change the return type. Taking into...

Hi @sewenew, Thanks for your work on the `RedMutex` stuff and of course all the tips in your review. I gave up on my original PR #32 as it just...

Hi @sewenew, I've commented on all your reviews in PR #32. Please confirm, if I should close PR #32. Thanks & regards