Willian Gustavo Veiga

Results 19 comments of Willian Gustavo Veiga

> Had the same issue. Applied your fix, now I have > > LoadError: cannot load such file -- uglifier > /home/developer/.rvm/gems/ruby-2.6.3/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' /home/developer/.rvm/gems/ruby-2.6.3/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' > /home/developer/.rvm/gems/ruby-2.6.3/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'...

I've followed the reproduction steps on [HEAD](https://github.com/solidusio/solidus/commit/8053d89e1e3f983f414a6fa636b7ab4cbfeae690) but my custom favicon is displayed in both frontend and backend. Could you please try with [HEAD](https://github.com/solidusio/solidus/commit/8053d89e1e3f983f414a6fa636b7ab4cbfeae690) ?

If you are still interested, probably you can take it over, @paulyoder or @jamiemccarthy. Please don't forget to consider @zzak's review and add @HallDJack as the co-author.

Maybe it's not related to the same thing, but [there was](https://github.com/solidusio/solidus/blob/c32e3074f4130d0069d2daaaebfdce67b7ab64e0/starter-app/db/migrate/001_create_users.rb#L4) a `login` column since day one. Considering [this comment](https://github.com/solidusio/solidus_auth_devise/commit/8ee9c748ec9bff1d90a61a1192e03fa9999c6dfd#diff-08a39940388ebab42d9f8314c302c8bb8493b8eda6216fd9c8909e5a9756ae8aR72), is it possible to consider it related to unfinished and/or...

Could you please add a changelog entry?

Could you please resolve the conflicts, add tests and a changelog entry?

Should we close this PR? It's an old draft with conflicts.

Could you please add tests and a changelog entry?

Could you please add a changelog entry?