Will Cosgrove

Results 33 comments of Will Cosgrove

@ankane no problem! I took out the tests, and changed `data-ahoy` to `data-ahoy-skip`. I left in the functionality to re-enable after a disable by setting `data-ahoy-skip="false"` because it added just...

It unfortunately takes a fair bit of code to patch it in, but it would be pretty trivial to add into the library itself. I was only adding this to...

@ankane maybe I'm just not seeing it, but couldn't you just drop the direct child operator and get the desired result? ```js ahoy.trackClicks(":not([data-no-track]) a:not([data-no-track])") ``` edit: Regardless, you are right...

Ah, I understand now why that selector doesn't work. It matches too much. Yeah I think this would need to be supported inside ahoy.js so that it can check for...

Is there any desire to also support the inverse operation? Enabling tracking nested under a certain data attribute? `data-ahoy` to turn it back on? Or just combine the two into...

Some more detective work: Running this in a console ```rb r.subscribe_with_timeout(8, "bar") { |on| on.subscribe { |*args| puts args.inspect puts r.client.instance_variable_get("@client") .instance_variable_get("@connection") .instance_variable_get("@sock") .instance_variable_get("@timeout") } } ``` Gives me this...

It looks like this is exactly this issue: #668 I agree with @alexnavis that timeout errors should probably not be considered for the reconnect/retry logic.

If anyone is looking for a non-hacky solution to this, the best I've found is to use the `without_reconnect` method which takes a block, and all nested redis calls will...

Yeah definitely. So say I have these serializers: ``` rb class BallotSerializer < ActiveModel::Serializer attributes :id, :name, :owner_id, :created_at, :updated_at has_many :candidates class CandidateSerializer < ActiveModel::Serializer attributes :id, :name, :vote_count...

@groyoh Wow, thanks for all your help! I'll try to respond to each thing in order. > Does a `Candidate` model have access to its `ballot`? It does not, because...