Whit Chapman
Whit Chapman
@tom-sherman I'll rebase and force push whenever #35 is merged, as well as, mark it ready for review.
I marked this ready for review for my last 2 commits. This will eventually be rebased once #35 is merged.
> @whitchapman @tom-sherman Thank you for your work and sorry for the very long delay. I am currently trying to clean up the repo and to move the pull requests...
Ok, I force pushed with all 5 commits -- I think I did it correctly; although, there are conflicts.
@tom-sherman Since my fork is from your fork of the original repo, I think you need to sync your fork first before I can sync mine -- how did this...
> My fork doesn't have that commit since Tom's fork doesn't have that commit. I would need to refork directly from rescript-lang and open a new PR -- definitely doable....
Ok, @cknitt I did what you suggested which resulted in modifying the PR to remove the test changes since the `test` folder has been removed in master.
Yes, my changes are as expected. It has been several months since I last looked at this, and I'm not familiar with the V3 changes. Is there a resource for...
``` let msg = switch e { | JsError(err) => switch Exn.message(err) { | Some(msg) => msg | None => "" } | _ => "Unexpected error occurred" } ```...