Weston Haught comments

Results 8 comments of


                                            Weston Haught

[webhook] support distribution authors who want to add their custom defaulting and validation

/assign

[webhook] support distribution authors who want to add their custom defaulting and validation

/unassign We've created a hook for unstructured, but there are some more good ideas about how to go further here.

webhook EOF errors

If dry-run is implicated but not well understood, we should move the feature to `Disabled`. With Beta features the standard should be to roll-back first and ask questions later.

Consistent and Correct Conditions

> /cc @whaught > Weston, is this covered by the stuff you've been doing? I've dealt with some of this - ObservedGeneration is now automatically moved (even on failure) and...

https://github.com/knative/serving/blob/2644ad1fbed6eb753080b4789595182cfdb23563/pkg/webhook/validate_unstructured.go#L104 I believe we ignore no-op updates. That said there may still be common-cases where we can avoid dry-run on Create.

`google_cloud_run_v2_service` and max_instance_count set to `0`

https://cloud.google.com/run/docs/configuring/max-instances#limits By default cloud run configures a maximum of 100 instances if the user does not specify any maximum.

Cloud Run Job `start_execution_token` breaks subsequent runs

I have a fix for this issue - it should be released to production within the next two weeks

Cloud Run Job `start_execution_token` breaks subsequent runs

Confirmed! We should be able to close this issue