Weston Pace
Weston Pace
Given that I understand webpack a little better now the includeAllSources option in karma would not work. Under the hood that is including all files that were instrumented. Webpack won't...
Let me know if you want me to make a pull request with this particular solution (or go ahead and implement it as it is simple enough). I wasn't sure...
This is still very much a draft. However, I have the basic path working. I will need to migrate over the existing scanner tests and test the various failure paths...
CC @save-buffer @marsupialtail who might be interested in this as well as we have spoken on similar topics
I'm out Monday & Tuesday. Maybe @jvanstraten can take a look? Otherwise I can get to this on Wednesday
> Intersting thoughts. I will take a look at the tool. It would be better if we can use it to validate things. But I am not sure if it...
I think the goal for a registry was to support conversion of custom exec nodes to Substrait. I agree that we don't want to expose Substrait internal classes though. @bkietz...
> Since this API is designed to be a test-only utility I wouldn't expect us to need to deal with custom exec nodes @bkietz That's a reasonable stance. I suppose...
Agreed that the test failures are unrelated. The Appveyor issues appears to be addressed already by https://github.com/apache/arrow/pull/13795
> please comment on the interface I like the python API. As for the C++: * `get_read_range` and `set_bounds` are inconsistent. They should be `get_xyz` and `set_xyz` although... * I...